generated from canonical/is-charms-template-repo
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove systemd config on relation departed #22
Merged
Thanhphan1147
merged 5 commits into
main
from
remove_systemd_config_and_hc_file_on_relation_departed
Feb 14, 2024
Merged
Remove systemd config on relation departed #22
Thanhphan1147
merged 5 commits into
main
from
remove_systemd_config_and_hc_file_on_relation_departed
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanhphan1147
changed the title
Remove systemd config and hc file on relation departed
Remove systemd config on relation departed
Feb 8, 2024
arturo-seijas
previously approved these changes
Feb 8, 2024
jdkandersson
reviewed
Feb 9, 2024
cbartz
approved these changes
Feb 13, 2024
Test coverage for 4e53cdf
Static code analysis report
|
javierdelapuente
approved these changes
Feb 14, 2024
Thanhphan1147
deleted the
remove_systemd_config_and_hc_file_on_relation_departed
branch
February 14, 2024 13:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When agent relation is removed the systemd config file is not removed, we should clean it up after stopping the service
Checklist
src-docs
urgent
,trivial
,complex
)